Re: [PATCH 1/2] net: macb: Fix compilation on systems without COMMON_CLK
From: Harini Katakam
Date: Tue Jun 25 2019 - 01:16:29 EST
On Tue, Jun 25, 2019 at 4:17 AM <Nicolas.Ferre@xxxxxxxxxxxxx> wrote:
> On 24/06/2019 at 11:57, Palmer Dabbelt wrote:
> > External E-Mail
> > On Mon, 24 Jun 2019 02:40:21 PDT (-0700), Nicolas.Ferre@xxxxxxxxxxxxx wrote:
> >> On 24/06/2019 at 08:16, Palmer Dabbelt wrote:
> >>> External E-Mail
> >>> The patch to add support for the FU540-C000 added a dependency on
> >>> COMMON_CLK, but didn't express that via Kconfig. This fixes the build
> >>> failure by adding CONFIG_MACB_FU540, which depends on COMMON_CLK and
> >>> conditionally enables the FU540-C000 support.
> >> Let's try to limit the use of #ifdef's throughout the code. We are
> >> using them in this driver but only for the hot paths and things that
> >> have an impact on performance. I don't think it's the case here: so
> >> please find another option => NACK.
> > OK. Would you accept adding a Kconfig dependency of the generic MACB driver on
> > COMMON_CLK, as suggested in the cover letter?
> Yes: all users of this peripheral have COMMON_CLK set.
> You can remove it from the PCI wrapper then.
Yes, +1, both Zynq and ZynqMP have COMMON_CLK set, thanks.