Re: [PATCH 0/2] Associate ddc adapters with connectors

From: Andrzej Pietrasiewicz
Date: Tue Jun 25 2019 - 06:14:33 EST

Hi Russell,

W dniu 25.06.2019 oÂ12:03, Russell King - ARM Linux admin pisze:
On Tue, Jun 25, 2019 at 11:46:34AM +0200, Andrzej Pietrasiewicz wrote:
It is difficult for a user to know which of the i2c adapters is for which
drm connector. This series addresses this problem.

The idea is to have a symbolic link in connector's sysfs directory, e.g.:

ls -l /sys/class/drm/card0-HDMI-A-1/i2c-2
lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/i2c-2 \
-> ../../../../soc/13880000.i2c/i2c-2

Don't you want the symlink name to be "i2c" or something fixed, rather
than the name of the i2c adapter? Otherwise, you seem to be encumbering
userspace with searching the directory to try and find the symlink.

Thank you for your comment. So you imagine something on the lines of:

lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \
-> ../../../../soc/13880000.i2c/i2c-2


This makes sense to me, I will send a v2.