Re: [PATCH v3 1/9] pinctrl: sunxi: v3s: introduce support for V3
From: Maxime Ripard
Date: Tue Jun 25 2019 - 10:10:33 EST
On Tue, Jun 25, 2019 at 03:57:15PM +0200, Linus Walleij wrote:
> On Mon, Jun 24, 2019 at 2:40 PM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote:
> > On Sun, Jun 23, 2019 at 12:37:53PM +0800, Icenowy Zheng wrote:
> > > Introduce the GPIO pins that is only available on V3 (not on V3s) to the
> > > V3s pinctrl driver.
> > >
> > > Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx>
> > > ---
> > > Changes in v3:
> > > - Fixed code alignment.
> > > - Fixed LVDS function number.
> > > - SUNXI_FUNCTION(0x2, "uart2"), /* TX */
> > > - SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 0)), /* PB_EINT0 */
> > > + SUNXI_FUNCTION(0x2, "uart2"), /* TX */
> > > + SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 0)), /* PB_EINT0 */
> > I'm not sure why all that churn is needed.
> > Looks good otherwise.
> Should I apply the patch or wait for a new version without the
> whitespace fixes?
I'd rather not have the indentation changes in that patch.
And we've sent the changes for 5.3 already, so it's going to be 5.4
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
Description: PGP signature