Re: [PATCH 1/2] mwifiex: dispatch/rotate from reorder table atomically

From: Brian Norris
Date: Tue Jun 25 2019 - 13:26:45 EST

On Mon, Jun 24, 2019 at 9:45 PM Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
> New warning:
> drivers/net/wireless/marvell/mwifiex/wmm.c: In function 'mwifiex_wmm_process_tx':
> drivers/net/wireless/marvell/mwifiex/wmm.c:1438:4: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
> mwifiex_11n_aggregate_pkt(priv, ptr, ptr_index, flags);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex/wmm.c:1406:16: note: 'flags' was declared here
> unsigned long flags;
> ^~~~~

Yikes! Not sure how I missed that, as I *thought* I had -Werror
enabled. Maybe things got lost a bit in the shuffles from GCC to Clang
for building our kernels internally.

Anyway, "used" is a bit generous here, since these are just useless
function arguments (never *actually* used now). I should remove these
args entirely.

> 2 patches set to Changes Requested.

Will send a v2.