Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs
From: Kees Cook
Date: Tue Jun 25 2019 - 16:18:27 EST
On Tue, Jun 25, 2019 at 10:49:01AM -0700, Joe Perches wrote:
> On Tue, 2019-06-25 at 10:31 -0700, Kees Cook wrote:
> > On Tue, Jun 25, 2019 at 09:52:23AM -0700, Joe Perches wrote:
> > > On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote:
> > > > In preparation to enabling -Wimplicit-fallthrough, mark switch
> > > > cases where we are expecting to fall through.
> > > 
> > > > This patch is part of the ongoing efforts to enable
> > > > -Wimplicit-fallthrough.
> > >
> > > Just enable the thing already.
> > Linus has been pretty clear about not wanting warning options enabled
> > without first fixing all the cases it warns about first.
> Hey Kees.
> I don't recall that particular tidbit. Got a link?
It was spread out over the discussion around removing __deprecated,
about enabling -Wvla, and in person at the kernel summit when asking
what approach to take for -Wimplicit-fallthrough.