Re: [PATCH 2/2] ASoC: codecs: ad193x: Reset DAC Control 1 register at probe
Date: Wed Jun 26 2019 - 08:16:41 EST
On 26.06.2019 14:23, Mark Brown wrote:
> On Wed, Jun 26, 2019 at 01:49:47PM +0300, Codrin Ciubotariu wrote:
>> Since the ad193x codecs have no software reset, we have to reinitialize the
>> registers after a hardware reset. For example, if we change the
>> device-tree between these resets, changing the audio format of the DAI link
>> from DSP_A with 8 TDM channels to I2S 2 channels, DAC Control 1 register
>> will remain configured for 8 channels. This patch resets this register at
>> probe to its default value.
> Would it not be more robust/complete to have a set of register defaults
> and write the whole lot out rather than individually going through and
> adding writes for specific registers as needed?
It would indeed. I will make two patches, one that implements what you
suggested, for the registers that we touch only, and another one that
will add AD193X_DAC_CTRL1 to these defaults. You can drop this patch.
Thanks and best regards,