Re: [PATCH v3] gpio: mockup: no need to check return value of debugfs_create functions
From: Greg Kroah-Hartman
Date: Wed Jun 26 2019 - 08:24:07 EST
On Wed, Jun 26, 2019 at 10:45:57AM +0200, Bartosz Golaszewski wrote:
> From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
> Cc: Bamvor Jian Zhang <bamv2005@xxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> [Bartosz: removed one more check for debugfs return value]
THank you for making this change. I'm on the road all this week and
have had very limited time for email and doing any work like this.
Your change looks good to me!