Re: [PATCH] xsk: Properly terminate assignment in xskq_produce_flush_desc
From: Daniel Borkmann
Date: Wed Jun 26 2019 - 10:30:46 EST
On 06/25/2019 08:23 PM, Nathan Chancellor wrote:
> Clang warns:
> In file included from net/xdp/xsk_queue.c:10:
> net/xdp/xsk_queue.h:292:2: warning: expression result unused
> WRITE_ONCE(q->ring->producer, q->prod_tail);
> include/linux/compiler.h:284:6: note: expanded from macro 'WRITE_ONCE'
> __u.__val; \
> ~~~ ^~~~~
> 1 warning generated.
> The q->prod_tail assignment has a comma at the end, not a semi-colon.
> Fix that so clang no longer warns and everything works as expected.
> Fixes: c497176cb2e4 ("xsk: add Rx receive functions and poll support")
> Link: https://github.com/ClangBuiltLinux/linux/issues/544
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>