Re: [PATCH 1/2] net: stmmac: Fix possible deadlock when disabling EEE support
From: David Miller
Date: Wed Jun 26 2019 - 12:10:59 EST
From: Jon Hunter <jonathanh@xxxxxxxxxx>
Date: Wed, 26 Jun 2019 11:23:21 +0100
> When stmmac_eee_init() is called to disable EEE support, then the timer
> for EEE support is stopped and we return from the function. Prior to
> stopping the timer, a mutex was acquired but in this case it is never
> released and so could cause a deadlock. Fix this by releasing the mutex
> prior to returning from stmmax_eee_init() when stopping the EEE timer.
> Fixes: 74371272f97f ("net: stmmac: Convert to phylink and remove phylib logic")
> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>
When targetting net-next for a set of changes, make this explicit and clear
by saying "[PATCH net-next ...] ..." in your Subject lines in the future.