Re: linux-next: build warning after merge of the mfd tree

From: Keerthy
Date: Thu Jun 27 2019 - 01:59:09 EST

On 27/06/19 10:41 AM, Stephen Rothwell wrote:
Hi Lee,

After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/regulator/lp87565-regulator.c: In function 'lp87565_regulator_probe':
drivers/regulator/lp87565-regulator.c:182:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
max_idx = LP87565_BUCK_3210;

Missed adding a break here. Can i send a patch on top of linux-next?

drivers/regulator/lp87565-regulator.c:183:2: note: here

Introduced by commit

7ee63bd74750 ("regulator: lp87565: Add 4-phase lp87561 regulator support")

I get these warnings because I am building with -Wimplicit-fallthrough
in attempt to catch new additions early. The gcc warning can be turned
off by adding a /* fall through */ comment at the point the fall through
happens (assuming that the fall through is intentional).