Re: [PATCH 5/5] bus: ti-sysc: Simplify cleanup upon failures in sysc_probe()
From: Suman Anna
Date: Thu Jun 27 2019 - 11:24:31 EST
On 6/27/19 7:11 AM, Tony Lindgren wrote:
> * Suman Anna <s-anna@xxxxxx> [190625 23:33]:
>> The clocks are not yet parsed and prepared until after a successful
>> sysc_get_clocks(), so there is no need to unprepare the clocks upon
>> any failure of any of the prior functions in sysc_probe(). The current
>> code path would have been a no-op because of the clock validity checks
>> within sysc_unprepare(), but let's just simplify the cleanup path by
>> returning the error directly.
>> While at this, also fix the cleanup path for a sysc_init_resets()
>> failure which is executed after the clocks are prepared.
> Sounds like this should get queued separately as a fix for v5.3-rc
> cycle, probably got broken with the recent ti-sysc init order changes.
Yeah, this patch does not depend on the previous 4 patches, so can be
picked up independently for v5.3-rc as well.