Re: [Linux-kernel-mentees][PATCH] doc: RCU callback locks need only _bh, not necessarily _irq
From: Steven Rostedt
Date: Thu Jun 27 2019 - 18:29:43 EST
On Thu, 27 Jun 2019 15:10:45 -0700
"Paul E. McKenney" <paulmck@xxxxxxxxxxxxx> wrote:
> On Thu, Jun 27, 2019 at 04:01:35PM -0600, Shuah Khan wrote:
> > On 6/27/19 3:01 PM, Jiunn Chang wrote:
> > >The UP.rst file calls for locks acquired within RCU callback functions
> > >to use _irq variants (spin_lock_irqsave() or similar), which does work,
> > >but can be overkill. This commit therefore instead calls for _bh variants
> > >(spin_lock_bh() or similar), while noting that _irq does work.
> > >
> > >Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxx>
> > Should this by Suggested-by?
> I wrote it and Jiunn converted my change to .rst, so I believe that
> this is correct as is.
Note, you did send Jiunn an explicit Signed-off-by when you wrote it,
correct? As Signed-off-by is equivalent to a signature.