Re: [PATCH RESEND v3] sched/isolation: Prefer housekeeping cpu in local node

From: Srikar Dronamraju
Date: Fri Jun 28 2019 - 04:44:50 EST


>
> -#endif /* CONFIG_NUMA */
> -
> /*
> * sched_numa_find_closest() - given the NUMA topology, find the cpu
> * closest to @cpu from @cpumask.
> * cpumask: cpumask to find a cpu from
> * cpu: cpu to be close to
> *
> - * returns: cpu, or >= nr_cpu_ids when nothing found (or !NUMA).
> + * returns: cpu, or nr_cpu_ids when nothing found.
> */
> int sched_numa_find_closest(const struct cpumask *cpus, int cpu)
> {
> -#ifdef CONFIG_NUMA
> int i, j = cpu_to_node(cpu);
>
> for (i = 0; i < sched_domains_numa_levels; i++) {
> @@ -1754,10 +1751,11 @@ int sched_numa_find_closest(const struct
> cpumask *cpus, int cpu)
> if (cpu < nr_cpu_ids)
> return cpu;
> }
> -#endif
> return nr_cpu_ids;
> }
>
> +#endif /* CONFIG_NUMA */
> +
> static int __sdt_alloc(const struct cpumask *cpu_map)
> {
> struct sched_domain_topology_level *tl;
>

Looks good to me.

Reviewed-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>

--
Thanks and Regards
Srikar Dronamraju