Re: [PATCH v4 11/12] drm/virtio: switch from ttm to gem shmem helpers

From: Gerd Hoffmann
Date: Fri Jun 28 2019 - 06:49:17 EST


> > static inline struct virtio_gpu_object*
> > virtio_gpu_object_ref(struct virtio_gpu_object *bo)

> The last users of these two helpers are removed with this patch. We
> can remove them.

patch 12/12 does that.

> > + bo = gem_to_virtio_gpu_obj(&shmem_obj->base);
> > + bo->base.base.funcs = &virtio_gpu_gem_funcs;
> Move this to virtio_gpu_create_object.

Fixed.

> > + ret = drm_gem_shmem_pin(&obj->base.base);
> The bo is attached for its entire lifetime, at least currently. Maybe
> we can use drm_gem_shmem_get_pages_sgt (and get rid of obj->pages).

Already checked this.
We can't due to the iommu quirks.

cheers,
Gerd