Re: [v2] coccinelle: semantic code search for missing of_node_put

From: Markus Elfring
Date: Fri Jun 28 2019 - 10:16:29 EST


>> +x =
>> +(of_â
>> +|of_â
>> +)@p1(...);
>
> Did you actually test this? I doubt that a position metavariable can be
> put on a ) of a disjunction.

Would you ever like to support this possibility?


>> +|return
>> +(x
>> +|of_fwnode_handle(x)
>> +);
>
> The original code is much more readable.

We have got different views around such specification variants.


> The internal representation will be the same.

I imagine that the Coccinelle software might evolve into additional directions.


Regards,
Markus