Re: [PATCH v7 1/2] fTPM: firmware TPM running in TEE

[Sasha Levin]

On Thu, Jun 27, 2019 at 02:31:35AM +0300, Jarkko Sakkinen wrote:
> On Tue, 2019-06-25 at 16:13 -0400, Sasha Levin wrote:
> > +static const uuid_t ftpm_ta_uuid =
> > +	UUID_INIT(0xBC50D971, 0xD4C9, 0x42C4,
> > +		  0x82, 0xCB, 0x34, 0x3F, 0xB7, 0xF3, 0x78, 0x96);
> > +
> > +/**
> > + * ftpm_tee_tpm_op_recv - retrieve fTPM response.
> > + *
>
> Should not have an empty line here.
>
> > + * @chip: the tpm_chip description as specified in driver/char/tpm/tpm.h.
> > + * @buf: the buffer to store data.
> > + * @count: the number of bytes to read.

Jarkko, w.r.t your comment above, there is an empty line between the
function name and variables in drivers/char/tpm, and in particular
tpm_crb.c which you authored and I used as reference. Do you want us to
diverge here?

--
Thanks,
Sasha