Re: [RFC] deadlock with flush_work() in UAS

From: Oliver Neukum
Date: Mon Jul 01 2019 - 07:16:29 EST


Am Mittwoch, den 26.06.2019, 10:38 -0400 schrieb Alan Stern:
> On Wed, 26 Jun 2019, Oliver Neukum wrote:
>
> > Am Montag, den 24.06.2019, 10:22 -0400 schrieb Alan Stern:
> > > But that pattern makes no sense; a driver would never use it. The
> > > driver would just do the reset itself.
> >
> > Correct. But UAS and storage themselves still need to use
> > WQ_MEM_RECLAIM for their workqueues, don't they?
>
> Perhaps so for uas. usb-storage uses a work queue only for scanning
> targets, which doesn't interfere with the block I/O pathway.

Are you sure? What about hub_tt_work? As far as I can tell, hub_quiesce
will flush it, hence it is used in error handling.

Regards
Oliver