Re: [PATCH v8 4/5] x86/xsave: Make XSAVE check the base CPUID features before enabling

From: Andi Kleen
Date: Mon Jul 01 2019 - 12:39:27 EST


>
> The commit for this patch in mainline
> (ccb18db2ab9d923df07e7495123fe5fb02329713) causes the kernel to hang on
> boot when passing the "nofxsr" option:

Thanks.

Hmm, I'm not sure nofxsr ever worked on 64bit. Certainly SSE cannot be
saved/restored in any other way during the context switch.

So even if you pass it successfully I doubt user space will really work
for very long. 64bit binaries require SSE.

AFAIK it is only useful on systems without SSE, presumably
running 32bit kernels.

Should check that case.

My recommended solution would be to just get rid of the option.

Presumably it's just some old chicken bit.

-Anfi