Re: [PATCH v3] Staging: most: fix coding style issues

From: kbuild test robot
Date: Mon Jul 01 2019 - 13:41:41 EST


Hi Gabriel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v5.2-rc6 next-20190625]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Gabriel-Beauchamp/Staging-most-fix-coding-style-issues/20190701-203804
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-rc1-7-g2b96cd8-dirty
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>


sparse warnings: (new ones prefixed by >>)


vim +308 drivers/staging/most/core.c

296
297 static ssize_t set_datatype_show(struct device *dev,
298 struct device_attribute *attr,
299 char *buf)
300 {
301 int i;
302 char *type = "unconfigured\n";
303
304 struct most_channel *c = to_channel(dev);
305
306 for (i = 0; i < ARRAY_SIZE(ch_data_type); i++) {
307 if (c->cfg.data_type & ch_data_type[i].most_ch_data_type) {
> 308 type = ch_data_type[i].name;
309 break;
310 }
311 }
312 return snprintf(buf, PAGE_SIZE, "%s", type);
313 }
314

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation