Re: [PATCH v2] Convert struct pid count to refcount_t

From: kbuild test robot
Date: Mon Jul 01 2019 - 14:47:18 EST


Hi "Joel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.2-rc6]
[cannot apply to next-20190625]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Joel-Fernandes-Google/Convert-struct-pid-count-to-refcount_t/20190702-003517
config: riscv-allnoconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=riscv

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> kernel/pid.c:44:30: warning: missing braces around initializer [-Wmissing-braces]
struct pid init_struct_pid = {
^
>> kernel/pid.c:44:30: warning: missing braces around initializer [-Wmissing-braces]
>> kernel/pid.c:44:30: warning: missing braces around initializer [-Wmissing-braces]
>> kernel/pid.c:44:30: warning: missing braces around initializer [-Wmissing-braces]
>> kernel/pid.c:44:30: warning: missing braces around initializer [-Wmissing-braces]

vim +44 kernel/pid.c

^1da177e Linus Torvalds 2005-04-16 43
e1e871af David Howells 2018-01-02 @44 struct pid init_struct_pid = {
e1e871af David Howells 2018-01-02 45 .count = ATOMIC_INIT(1),
e1e871af David Howells 2018-01-02 46 .tasks = {
e1e871af David Howells 2018-01-02 47 { .first = NULL },
e1e871af David Howells 2018-01-02 48 { .first = NULL },
e1e871af David Howells 2018-01-02 49 { .first = NULL },
e1e871af David Howells 2018-01-02 50 },
e1e871af David Howells 2018-01-02 51 .level = 0,
e1e871af David Howells 2018-01-02 52 .numbers = { {
e1e871af David Howells 2018-01-02 53 .nr = 0,
e1e871af David Howells 2018-01-02 54 .ns = &init_pid_ns,
e1e871af David Howells 2018-01-02 55 }, }
e1e871af David Howells 2018-01-02 56 };
^1da177e Linus Torvalds 2005-04-16 57

:::::: The code at line 44 was first introduced by commit
:::::: e1e871aff3ded26348c631b1370e257d401cd22d Expand INIT_STRUCT_PID and remove

:::::: TO: David Howells <dhowells@xxxxxxxxxx>
:::::: CC: David Howells <dhowells@xxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip