Re: [PATCH -next] sample/mdev/mbochs: remove set but not used variable 'mdev_state'

From: Alex Williamson
Date: Tue Jul 02 2019 - 14:02:20 EST


On Sat, 25 May 2019 21:53:49 +0800
YueHaibing <yuehaibing@xxxxxxxxxx> wrote:

> Fixes gcc '-Wunused-but-set-variable' warning:
>
> samples/vfio-mdev/mbochs.c: In function mbochs_ioctl:
> samples/vfio-mdev/mbochs.c:1188:21: warning: variable mdev_state set but not used [-Wunused-but-set-variable]
>
> It's not used any more since commit 104c7405a64d ("vfio:
> add edid support to mbochs sample driver")
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> samples/vfio-mdev/mbochs.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/samples/vfio-mdev/mbochs.c b/samples/vfio-mdev/mbochs.c
> index b038aa9f5a70..ac5c8c17b1ff 100644
> --- a/samples/vfio-mdev/mbochs.c
> +++ b/samples/vfio-mdev/mbochs.c
> @@ -1185,9 +1185,6 @@ static long mbochs_ioctl(struct mdev_device *mdev, unsigned int cmd,
> {
> int ret = 0;
> unsigned long minsz, outsz;
> - struct mdev_state *mdev_state;
> -
> - mdev_state = mdev_get_drvdata(mdev);
>
> switch (cmd) {
> case VFIO_DEVICE_GET_INFO:

Applied to vfio next branch for 5.3. Thanks!

Alex