Re: [PATCH net-next] rxrpc: Fix uninitialized error code in rxrpc_send_data_packet()

From: David Miller
Date: Tue Jul 02 2019 - 15:09:47 EST

From: David Howells <dhowells@xxxxxxxxxx>
Date: Tue, 02 Jul 2019 15:55:28 +0100

> With gcc 4.1:
> net/rxrpc/output.c: In function ʽrxrpc_send_data_packetʼ:
> net/rxrpc/output.c:338: warning: ʽretʼ may be used uninitialized in this function
> Indeed, if the first jump to the send_fragmentable label is made, and
> the address family is not handled in the switch() statement, ret will be
> used uninitialized.
> Fix this by BUG()'ing as is done in other places in rxrpc where internal
> support for future address families will need adding. It should not be
> possible to reach this normally as the address families are checked
> up-front.
> Fixes: 5a924b8951f835b5 ("rxrpc: Don't store the rxrpc header in the Tx queue sk_buffs")
> Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>

Applied, thanks David.