Re: [PATCH v4 2/2] drm/panfrost: Use drm_gem_map_offset()

From: Rob Herring
Date: Tue Jul 02 2019 - 22:32:40 EST

On Thu, Jun 27, 2019 at 9:53 AM Steven Price <steven.price@xxxxxxx> wrote:
> panfrost_ioctl_mmap_bo() contains a reimplementation of
> drm_gem_map_offset() but with a bug - it allows mapping imported
> objects (without going through the exporter). Fix this by switching to
> use the newly renamed drm_gem_map_offset() function instead which has
> the bonus of simplifying the code.

While it may have been a bug, it worked (by some definition of
worked). Now mesa breaks on importing buffers which always get
mmapped. So we need to revert this, get import mmaps to work, or drop
mmapping of imports and backport that to 19.1. I don't think there
should be any need to mmap imports.