Re: [PATCH 06/30] drm/amdgpu: Use kmemdup rather than duplicating its implementation

From: Emil Velikov
Date: Wed Jul 03 2019 - 11:21:38 EST


On Wed, 3 Jul 2019 at 14:15, Fuqian Huang <huangfq.daxian@xxxxxxxxx> wrote:
>
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memset, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memset.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@xxxxxxxxx>
Fuqian please add reviewed-by and other tags when sending new revisions.

Fwiw the patch is:
Reviewed-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>

-Emil