Re: [PATCH v2 09/35] infiniband: Use kmemdup rather than duplicating its implementation
From: Jason Gunthorpe
Date: Wed Jul 03 2019 - 13:43:46 EST
On Thu, Jul 04, 2019 at 12:27:42AM +0800, Fuqian Huang wrote:
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memcpy, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.
> Signed-off-by: Fuqian Huang <huangfq.daxian@xxxxxxxxx>
> Changes in v2:
> - Fix a typo in commit message (memset -> memcpy)
> drivers/infiniband/hw/i40iw/i40iw_cm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to rdma for-next