Re: Re: [PATCH V2 2/2] PCI: Add NI-Serial PXI/PXIe+485 device IDs

[Greg KH]

On Thu, Jul 04, 2019 at 06:58:39AM +0000, Je Yen Tam wrote:
> > On Wed, Jul 03, 2019 at 12:25:16AM -0700, jeyentam wrote:
> > > Add NI PXIe-RS232, PXI-RS485 and PXIe-RS485 device IDs.
> > >
> > > Signed-off-by: jeyentam <je.yen.tam@xxxxxx>
> > > ---
> > >  include/linux/pci_ids.h | 12 ++++++++++++
> > >  1 file changed, 12 insertions(+)
> > 
> > You have read the comment at the top of this file, right?  If so, why 
> > are you adding these entries?
> 
> Yes, but I think these entries should be added in because the NI-Serial PXI 
> (RS232) device IDs already been defined in this file originally, so now I'm 
> adding the newly supported NI-Serial PXI (RS485), PXIe (RS232) and PXIe 
> (RS485) device IDs into here as they are the same product.

No, do not add new device ids to this file, only put them in the single
file that needs it.  This file is for device ids that are shared across
multiple drivers/files.

You should not need to touch this file at all.

thanks,

greg k-h