Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code

From: Geert Uytterhoeven
Date: Thu Jul 04 2019 - 07:49:31 EST

Hi Arnd,

On Thu, Jul 4, 2019 at 1:38 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> gcc-9 complains about a blatant uninitialized variable use that
> all earlier compiler versions missed:
> drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]

Actually gcc-4.1 warned about that one too ;-)

So either I must have missed that warning when it appeared first,
or I must have concluded wrongly that it was a false positive.
Sorry for that...

> Return -EINVAL instead here.
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 059c53b32329 ("iio: adc: Add Renesas GyroADC driver")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds