Re: [PATCH 6/9] Add a general, global device notification watch list [ver #5]

From: David Howells
Date: Thu Jul 04 2019 - 12:04:52 EST

Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> Don't we need a manpage and a kselftest for it?

I've got part of a manpage, but it needs more work.

How do you do a kselftest for this when it does nothing unless hardware events

> > + u64 id = 0; /* Might want to allow dev# here. */
> I don't understand the comment here, what does "dev#" refer to?

This is really for mount subtree watches, so I'm removing it for now.

The reason it's there is because a mount object may have multiple watches, but
each watch is set on a dentry within that mount, and it doesn't have to be the
same dentry each time. The queue is shared between all the dentries, and the
ID is used (a) to label them so that they can be manually removed, (b) to
match them to each dentry when the notification is being propagated rootwards
along the tree and (c) to avoid adding another field to struct dentry.