Re: [PATCH] Bluetooth: hci_ldisc: check for missing tty operations

From: Marcel Holtmann
Date: Sat Jul 06 2019 - 06:35:49 EST


Hi Vladis,

> Certain ttys lack operations (eg: pty_unix98_ops) which still can be
> called by certain hci uart proto (eg: mrvl, ath). Currently this leads
> to execution at address 0x0. Fix this by adding checks for missing tty
> operations.

so I really prefer that we just fail setting the line discipline. These drivers need to check that the underlying transport has all the operations available they need. We can not just ignore them.

Regards

Marcel