Re: [PATCH 3/3] platform//x86/pcengines-apuv2: update gpio button definition

From: Enrico Weigelt, metux IT consult
Date: Mon Jul 08 2019 - 15:28:16 EST

On 04.07.19 11:02, Florian Eckert wrote:
> * Add the gpio number, so the button subsystem can find the right gpio.
> * Change also the keycode from KEY_SETUP to KEY_RESTART, because it
> seems more expressive to me and in the Alix-Board, which is the
> predecessor, there isthis keycode defined too. I think this is also
> intended by Pcengines. Also many embedded systems defined in the kernel
> use this key code as well.

In general, I'm not opposed to that, but I'll first have to check trough
various userland code to make sure that it doesn't break
anything in the field, before I can give my ack.


Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@xxxxxxxxx -- +49-151-27565287