Re: [PATCHv2 4/4] tty: n_gsm: add ioctl to map serial device to mux'ed tty

From: Martin HundebÃll
Date: Tue Jul 09 2019 - 02:52:39 EST

On 09/07/2019 08.49, Jiri Slaby wrote:
On 09. 07. 19, 8:46, Martin HundebÃll wrote:
@@ -2623,6 +2624,9 @@ static int gsmld_ioctl(struct tty_struct *tty, struct file *file,
if (copy_from_user(&c, (void *)arg, sizeof(c)))
return -EFAULT;
return gsm_config(gsm, &c);
+ base = mux_num_to_base(gsm);
+ return put_user(base, (int __user *)arg);
I am not sure, but do you need the local variable at all?

No, I kept it around just to avoid too many parenthesis in the put_user() call.

Your call.

// Martin