RE: [v4 1/6] dt-bindings: media: Document bindings for DW MIPI CSI-2 Host

[Luis de Oliveira]

Hi Eugen,


From: Eugen.Hristev@xxxxxxxxxxxxx <Eugen.Hristev@xxxxxxxxxxxxx>
Date: Wed, Jul 10, 2019 at 07:53:02

> 
> 
> On 09.07.2019 20:08, Luis de Oliveira wrote:
> 
> > 
> > Hi Eugen,
> > 
> > 
> > From: Eugen.Hristev@xxxxxxxxxxxxx <Eugen.Hristev@xxxxxxxxxxxxx>
> > Date: Tue, Jul 09, 2019 at 15:33:50
> > 
> >>
> >>
> >> On 11.06.2019 22:20, Luis Oliveira wrote:
> >>> From: Luis Oliveira <lolivei@xxxxxxxxxxxx>
> >>>
> >>> Add bindings for Synopsys DesignWare MIPI CSI-2 host.
> >>>
> >>> Signed-off-by: Luis Oliveira <lolivei@xxxxxxxxxxxx>
> >>> ---
> >>> Changelog
> >>> v3-v4
> >>> - remove "plat" from the block name @rob @laurent
> >>> - remove "phy-names" when single-entry @rob
> >>> - remove "snps,output-type" -> went to the driver config @laurent
> >>>
> >>>    .../devicetree/bindings/media/snps,dw-csi.txt      | 41 ++++++++++++++++++++++
> >>>    1 file changed, 41 insertions(+)
> >>>    create mode 100644 Documentation/devicetree/bindings/media/snps,dw-csi.txt
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/media/snps,dw-csi.txt b/Documentation/devicetree/bindings/media/snps,dw-csi.txt
> >>> new file mode 100644
> >>> index 0000000..613b7f9
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/media/snps,dw-csi.txt
> >>> @@ -0,0 +1,41 @@
> >>> +Synopsys DesignWare CSI-2 Host controller
> >>> +
> >>> +Description
> >>> +-----------
> >>> +
> >>> +This HW block is used to receive image coming from an MIPI CSI-2 compatible
> >>> +camera.
> >>> +
> >>> +Required properties:
> >>> +- compatible		: shall be "snps,dw-csi"
> >>> +- reg			: physical base address and size of the device memory
> >>> +			  mapped registers;
> >>> +- interrupts		: DW CSI-2 Host interrupts
> >>> +- phys			: List of one PHY specifier (as defined in
> >>> +			  Documentation/devicetree/bindings/phy/phy-bindings.txt).
> >>> +			  This PHY is a MIPI DPHY working in RX mode.
> >>> +- resets		: Reference to a reset controller (optional)
> >>> +
> >>> +The per-board settings:
> >>> + - port sub-node describing a single endpoint connected to the camera as
> >>> +   described in video-interfaces.txt[1].
> >>> +
> >>> +Example:
> >>> +
> >>> +	csi2: csi2@3000 {
> >>> +		compatible = "snps,dw-csi";
> >>> +		#address-cells = <1>;
> >>> +		#size-cells = <0>;
> >>> +		reg = < 0x03000 0x7FF>;
> >>> +		phys = <&mipi_dphy_rx>;
> >>> +		resets = <&dw_rst 1>;
> >>> +		interrupts = <2>;
> >>> +
> >>> +		port@0 {
> >>> +			reg = <0>;
> >>> +			csi_ep1: endpoint {
> >>> +				remote-endpoint = <&camera_1>;
> >>> +				data-lanes = <1 2>;
> >>> +			};
> >>
> >> Hello Luis,
> >>
> >> Which is the output port (endpoint) : how to connect the output of
> >> csi2host to another node ?
> >> I mean, the second port of this block, or, how is the data taken from
> >> csi2host ?
> >>
> > 
> > I understand your question, I think you guessed this is not the complete
> > pipeline (I have a top driver that interacts with this one).
> > I was not planning to submit it, do you think I should?
> 
> Yes please, you can have the patch with subject DO NOT MERGE if you do 
> not want that patch to be included in the kernel and just for reference.
> but it would help me in understanding your setup
> 
> Thanks !
> 
Ok, thank you. I will included it next.

> > 
> > The behavior is very similar with this one
> > ./drivers/media/platform/exynos4-is/media-dev.c
> > 
> > 
> >> Thanks,
> >>
> >> Eugen
> >>
> >>> +		};
> >>> +	};
> >>>
> > 
> > Thanks,
> > Luis
> >