Re: [PATCH v9 3/6] mm,thp: stats for file backed THP

From: Johannes Weiner
Date: Wed Jul 10 2019 - 13:59:12 EST


On Mon, Jun 24, 2019 at 05:12:43PM -0700, Song Liu wrote:
> @@ -413,6 +413,7 @@ struct mem_size_stats {
> unsigned long lazyfree;
> unsigned long anonymous_thp;
> unsigned long shmem_thp;
> + unsigned long file_thp;

This appears to be unused.

Other than that, this looks good to me. It's a bit of a shame that
it's not symmetrical with the anon THP stats, but that already
diverged on shmem pages, so not your fault... Ah well.

Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>