Re: [PATCH] Staging: rtl8723bs: hal: rtl8723bs_recv.c: Fix code style

From: Joe Perches
Date: Wed Jul 10 2019 - 18:31:27 EST


On Mon, 2019-07-08 at 12:56 +0300, Fatih ALTINPINAR wrote:
> Fixed a coding stlye issue. Removed braces from a single statement if
> block.
>
> Signed-off-by: Fatih ALTINPINAR <fatihaltinpinar@xxxxxxxxx>
> ---
> drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
> index e23b39ab16c5..71a4bcbeada9 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
> @@ -449,9 +449,8 @@ s32 rtl8723bs_init_recv_priv(struct adapter *padapter)
> skb_reserve(precvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment));
> }
>
> - if (!precvbuf->pskb) {
> + if (!precvbuf->pskb)
> DBG_871X("%s: alloc_skb fail!\n", __func__);
> - }

You could delete the block instead.
alloc_skb failures already do a dump_stack()