Re: [PATCH v2] ASoC: audio-graph-card: Constify reg in graph_get_dai_id

From: Kuninori Morimoto
Date: Thu Jul 11 2019 - 23:37:55 EST



Hi Nathan

> clang errors:
>
> sound/soc/generic/audio-graph-card.c:87:7: error: assigning to 'u32 *'
> (aka 'unsigned int *') from 'const void *' discards qualifiers
> [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
> reg = of_get_property(node, "reg", NULL);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
>
> Move the declaration up a bit to keep the reverse christmas tree look.
>
> Fixes: c152f8491a8d ("ASoC: audio-graph-card: fix an use-after-free in graph_get_dai_id()")
> Link: https://github.com/ClangBuiltLinux/linux/issues/600
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> ---

Maybe

ec3042ad39d4e2ddbc3a3344f90bb10d8feb53bc
("ASoC: audio-graph-card: add missing const at graph_get_dai_id()")

Thank you for your help !!
Best regards
---
Kuninori Morimoto