Re: [RFC] Fix python feature detection

From: Joel Fernandes
Date: Sun Jul 14 2019 - 13:58:15 EST


On Sun, Jul 14, 2019 at 05:40:06PM +0200, Jiri Olsa wrote:
> On Sun, Jul 07, 2019 at 10:44:17AM -0400, Joel Fernandes (Google) wrote:
> > I am having a hard time building BPF samples by doing a make in
> > samples/bpf. While I am debugging that, I ran into the Python issue.
> > Even though the system has libpython2.7-dev:
> >
> > If I just do a 'make' inside tools/build/feature/ I get:
> > Python.h: No such file or directory
>
> because you don't have FLAGS_PYTHON_EMBED set?
>
> >
> > This led me to this patch which fixes Python feature detection for me.
> > I am not sure if it is the right fix for Python since it is hardcoded
> > for Python version 2, but I thought it could be useful.
>
> we detect python in tools/perf/Makefile.config and
> set FLAGS_PYTHON_EMBED properly
>
> it's supposed to be set by a project using tools/build
> for feature detection.. what are you building? AFAICS
> samples/bpf do not use tools/build

Yes, you are right. Never mind then. I was debugging feature detection and
ended doing a make in this directory like:

make <something>.bin which works always except for python. But as you said it
is likely a non-issue.

thanks!

- Joel