Re: [PATCH] dt-bindings: riscv: Limit cpus schema to only check RiscV 'cpu' nodes
From: Paul Walmsley
Date: Tue Jul 16 2019 - 11:24:03 EST
On Tue, 16 Jul 2019, Rob Herring wrote:
> On Wed, Jun 26, 2019 at 6:00 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> > Matching on the 'cpus' node was a bad choice because the schema is
> > incorrectly applied to non-RiscV cpus nodes. As we now have a common cpus
> > schema which checks the general structure, it is also redundant to do so
> > in the Risc-V CPU schema.
> > The downside is one could conceivably mix different architecture's cpu
> > nodes or have typos in the compatible string. The latter problem pretty
> > much exists for every schema.
> > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> > ---
> > .../devicetree/bindings/riscv/cpus.yaml | 143 ++++++++----------
> > 1 file changed, 61 insertions(+), 82 deletions(-)
> Paul, do you plan to apply this? I have several fixes to send to Linus
> if you want me to include this.
Please go ahead:
Acked-by: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
and thanks for asking.