Re: [PATCH v2 2/2] leds: Add control of the voltage/current regulator to the LED core

From: Jean-Jacques Hiblot
Date: Wed Jul 17 2019 - 09:47:30 EST

On 16/07/2019 12:50, Daniel Thompson wrote:
On Mon, Jul 15, 2019 at 05:56:57PM +0200, Jean-Jacques Hiblot wrote:
A LED is usually powered by a voltage/current regulator. Let the LED core
This is almost certainly nitpicking but since there's enough other
review comments that you will have to respin anyway ;-)
No problems. comments are welcome.
Is an LED really "usually powered by a voltage/current regulator"? Some
LEDs have a software controlled power supply but I'm not sure it is
the usual case.
True. I'll reword this.
Likewise its a little confusing to be talking about LEDs with an
external current regulator since, although that is possible, it is also
one the main features provided by LED driver chips.

In my experience LED drivers are quite often current sinks. In that case the power is provided externally, and sometimes by a managed regulator.