RE: [PATCH 2/3] firmware: imx: scu-pd: Add mu_b side PD range

From: Aisheng Dong
Date: Wed Jul 17 2019 - 23:29:12 EST


> From: Daniel Baluta <daniel.baluta@xxxxxxx>
> Sent: Thursday, July 4, 2019 3:04 AM
> Subject: [PATCH 2/3] firmware: imx: scu-pd: Add mu_b side PD range
>
> LSIO subsystem contains 14 MU instances.
>
> 5 MUs to communicate between AP <-> SCU
> - side-A PD range managed by AP
> - side-B PD range managed by SCU
>
> 9 MUs to communicate between AP <-> M4

The left 9MUs are general and can be used by all cores,
e.g AP/M4/DSP.
So below description is not correct.

> - side-A PD range managed by AP
> - side-B PD range managed by AP
>
> Signed-off-by: Daniel Baluta <daniel.baluta@xxxxxxx>
> ---
> drivers/firmware/imx/scu-pd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c
> index 950d30238186..30adc3104347 100644
> --- a/drivers/firmware/imx/scu-pd.c
> +++ b/drivers/firmware/imx/scu-pd.c
> @@ -93,6 +93,7 @@ static const struct imx_sc_pd_range
> imx8qxp_scu_pd_ranges[] = {
> { "kpp", IMX_SC_R_KPP, 1, false, 0 },
> { "fspi", IMX_SC_R_FSPI_0, 2, true, 0 },
> { "mu_a", IMX_SC_R_MU_0A, 14, true, 0 },
> + { "mu_b", IMX_SC_R_MU_5B, 9, true, 0 },

Should start from 5?
{ "mu_b", IMX_SC_R_MU_5B, 9, true, 5 },

Regards
Aisheng

>
> /* CONN SS */
> { "usb", IMX_SC_R_USB_0, 2, true, 0 },
> --
> 2.17.1