Re: [PATCH] mac80211: don't warn about CW params when not using them
From: Stanislaw Gruszka
Date: Thu Jul 18 2019 - 03:45:27 EST
On Wed, Jul 17, 2019 at 06:57:12PM -0700, Brian Norris wrote:
> ieee80211_set_wmm_default() normally sets up the initial CW min/max for
> each queue, except that it skips doing this if the driver doesn't
> support ->conf_tx. We still end up calling drv_conf_tx() in some cases
> (e.g., ieee80211_reconfig()), which also still won't do anything
> useful...except it complains here about the invalid CW parameters.
> Let's just skip the WARN if we weren't going to do anything useful with
> the parameters.
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> Noticed because rtw88 does not currently implement .conf_tx()
> I think there are several ways to slice this one. I picked one fix,
> which may not be the best one.
Fix looks fine for me. However I think rtw88 should implement
drv_conf_tx() because parameters can be different on different
network setups and maybe more important WMM/AC parameters become
quite recently part of ETSI regulatory.