Re: [PATCH 3/5] sched/fair: rework load_balance
From: Peter Zijlstra
Date: Sat Jul 20 2019 - 07:31:34 EST
On Fri, Jul 19, 2019 at 04:02:15PM +0200, Vincent Guittot wrote:
> On Fri, 19 Jul 2019 at 14:54, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> > On Fri, Jul 19, 2019 at 09:58:23AM +0200, Vincent Guittot wrote:
> > > -void fix_small_imbalance(struct lb_env *env, struct sd_lb_stats *sds)
> > Maybe strip this out first, in a separate patch. It's all magic doo-doo.
> If I remove that 1st, we will have commit in the branch that might
> regress some performance temporarily and bisect might spot it while
> looking for a culprit, isn't it ?
Maybe; but at least for review it is much better to not have it all
squashed in one patch.