Re: [PATCH v2] iommu/amd: fix a crash in iova_magazine_free_pfns

From: Linus Torvalds
Date: Sun Jul 21 2019 - 12:58:27 EST


On Thu, Jul 11, 2019 at 9:18 AM Qian Cai <cai@xxxxxx> wrote:
>
> The commit b3aa14f02254 ("iommu: remove the mapping_error dma_map_ops
> method") incorrectly changed the checking from dma_ops_alloc_iova() in
> map_sg() causes a crash under memory pressure as dma_ops_alloc_iova()
> never return DMA_MAPPING_ERROR on failure but 0, so the error handling
> is all wrong.

This one seems to have fallen through the cracks.

Applied directly.

Maybe it's hiding in some fixes tree that I haven't gotten a pull
request for yet?

Linus