Re: [PATCH glibc] Linux: Include <linux/sockios.h> in <bits/socket.h> under __USE_MISC

From: Arnd Bergmann
Date: Mon Jul 22 2019 - 07:35:07 EST

On Mon, Jul 22, 2019 at 1:31 PM Florian Weimer <fweimer@xxxxxxxxxx> wrote:
> Historically, <asm/socket.h> (which is included from <bits/socket.h>)
> provided ioctl operations for sockets. User code accessed them
> through <sys/socket.h>. The kernel UAPI headers have removed these
> definitions in favor of <linux/sockios.h>. This commit makes them
> available via <sys/socket.h> again.

Looks good to me.

I wonder if we should still do these two changes in the kernel:

- include asm/socket.h from linux/socket.h for consistency
- move the defines that got moved from asm/sockios.h to linux/sockios.h
back to the previous location to help anyone who is user
newer kernel headers with older glibc headers.