Re: [PATCH] leds: ktd2692: Fix a typo in the name of a constant

From: Jacek Anaszewski
Date: Mon Jul 22 2019 - 16:14:06 EST


Hi Christophe,

Thank you for the patch.

On 7/21/19 11:05 PM, Christophe JAILLET wrote:
> There is a typo in KTD2962_MM_MIN_CURR_THRESHOLD_SCALE. 6 and 9 are
> switched in 2962.
>
> Define and use KTD2692_MM_MIN_CURR_THRESHOLD_SCALE instead.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> drivers/leds/leds-ktd2692.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-ktd2692.c b/drivers/leds/leds-ktd2692.c
> index 45296aaca9da..44db748c570e 100644
> --- a/drivers/leds/leds-ktd2692.c
> +++ b/drivers/leds/leds-ktd2692.c
> @@ -22,7 +22,7 @@
> /* Value related the movie mode */
> #define KTD2692_MOVIE_MODE_CURRENT_LEVELS 16
> #define KTD2692_MM_TO_FL_RATIO(x) ((x) / 3)
> -#define KTD2962_MM_MIN_CURR_THRESHOLD_SCALE 8
> +#define KTD2692_MM_MIN_CURR_THRESHOLD_SCALE 8
>
> /* Value related the flash mode */
> #define KTD2692_FLASH_MODE_TIMEOUT_LEVELS 8
> @@ -253,7 +253,7 @@ static void ktd2692_setup(struct ktd2692_context *led)
> ktd2692_expresswire_reset(led);
> gpiod_direction_output(led->aux_gpio, KTD2692_LOW);
>
> - ktd2692_expresswire_write(led, (KTD2962_MM_MIN_CURR_THRESHOLD_SCALE - 1)
> + ktd2692_expresswire_write(led, (KTD2692_MM_MIN_CURR_THRESHOLD_SCALE - 1)
> | KTD2692_REG_MM_MIN_CURR_THRESHOLD_BASE);
> ktd2692_expresswire_write(led, KTD2692_FLASH_MODE_CURR_PERCENT(45)
> | KTD2692_REG_FLASH_CURRENT_BASE);
>

Applied.

--
Best regards,
Jacek Anaszewski