Re: [PATCH] net: usb: Merge cpu_to_le32s + memcpy to put_unaligned_le32
From: David Miller
Date: Mon Jul 22 2019 - 23:43:54 EST
From: Chuhong Yuan <hslester96@xxxxxxxxx>
Date: Tue, 23 Jul 2019 10:16:27 +0800
> David Miller <davem@xxxxxxxxxxxxx> 于2019年7月23日周二 上午9:22写道：
>> From: Chuhong Yuan <hslester96@xxxxxxxxx>
>> Date: Mon, 22 Jul 2019 15:41:34 +0800
>> > Merge the combo uses of cpu_to_le32s and memcpy.
>> > Use put_unaligned_le32 instead.
>> > This simplifies the code.
>> > Signed-off-by: Chuhong Yuan <hslester96@xxxxxxxxx>
>> Isn't the skb->data aligned to 4 bytes in these situations?
>> If so, we should use the aligned variants.
>> Thank you.
> I have checked the five changed files.
> I find that they all have used get_unaligned_le32 for skb->data
> according to my previous applied patches and existing code.
> So I think the skb->data is unaligned in these situations.
Thank you for checking.
Patch applied to net-next.