Re: [PATCH 1/5] arm64: dts: qcom: sdm845: Add unit name to soc node

[Vinod Koul]

On 23-07-19, 07:50, Stephen Boyd wrote:
> Quoting Vinod Koul (2019-07-22 05:34:18)
> > We get a warning about missing unit name for soc node, so add it.
> > 
> > arch/arm64/boot/dts/qcom/sdm845.dtsi:623.11-2814.4: Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
> > 
> > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> > ---
> 
> Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>

Thanks for the review
> 
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > index 601cfb078bd5..e81f4a6d08ce 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > @@ -620,7 +620,7 @@
> >                 method = "smc";
> >         };
> >  
> > -       soc: soc {
> > +       soc: soc@0 {
> 
> This is kinda sad, but ok. Maybe you can apply this fix to at least all
> the qcom boards then.

Yeah that is the idea, start with sdm845 and 'reduce' the warns on all
qcom dts files

-- 
~Vinod