Re: [PATCH v2 3/3] sgi-gru: Use __get_user_pages_fast in atomic_pte_lookup

From: Bharath Vedartham
Date: Wed Jul 24 2019 - 16:28:33 EST

On Wed, Jul 24, 2019 at 09:09:29AM -0700, Christoph Hellwig wrote:
> I think the atomic_pte_lookup / non_atomic_pte_lookup helpers
> should simply go away. Most of the setup code is common now and should
> be in the caller where it can be shared. Then just do a:
> if (atomic) {
> __get_user_pages_fast()
> } else {
> get_user_pages_fast();
> }
> and we actually have an easy to understand piece of code.

That makes sense. I ll do that and send v3. I ll probably cut down on a
patch and try to fold all the changes into a single patch removing the
*pte_lookup helpers.