Re: [PATCH v1 1/1] Fix uninitialized variable in ipmb_dev_int.c
From: Corey Minyard
Date: Wed Jul 24 2019 - 16:53:48 EST
On Wed, Jul 24, 2019 at 03:32:57PM -0400, Asmaa Mnebhi wrote:
> ret at line 112 of ipmb_dev_int.c is uninitialized which
> results in a warning during build regressions.
> This warning was found by build regression/improvement
> testing for v5.3-rc1.
Applied, thanks for sticking with it :).
> Reported-by: build regression/improvement testing for v5.3-rc1.
> Fixes: 51bd6f291583 ("Add support for IPMB driver")
> Signed-off-by: Asmaa Mnebhi <Asmaa@xxxxxxxxxxxx>
> drivers/char/ipmi/ipmb_dev_int.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c
> index 5720433..285e0b8 100644
> --- a/drivers/char/ipmi/ipmb_dev_int.c
> +++ b/drivers/char/ipmi/ipmb_dev_int.c
> @@ -76,7 +76,7 @@ static ssize_t ipmb_read(struct file *file, char __user *buf, size_t count,
> struct ipmb_dev *ipmb_dev = to_ipmb_dev(file);
> struct ipmb_request_elem *queue_elem;
> struct ipmb_msg msg;
> - ssize_t ret;
> + ssize_t ret = 0;
> memset(&msg, 0, sizeof(msg));