Re: [PATCH] rtlwifi: remove unneeded function _rtl_dump_channel_map()

From: Pkshih
Date: Wed Jul 24 2019 - 22:51:04 EST


On Wed, 2019-07-24 at 22:10 +0800, YueHaibing wrote:
> Now _rtl_dump_channel_map() does not do any actual
> thing using the channel. So remove it.
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> Âdrivers/net/wireless/realtek/rtlwifi/regd.c | 18 ------------------
> Â1 file changed, 18 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/regd.c
> b/drivers/net/wireless/realtek/rtlwifi/regd.c
> index 6ccb5b9..c10432c 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/regd.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/regd.c
> @@ -276,22 +276,6 @@ static void _rtl_reg_apply_world_flags(struct wiphy
> *wiphy,
> Â return;
> Â}
> Â
> -static void _rtl_dump_channel_map(struct wiphy *wiphy)
> -{
> - enum nl80211_band band;
> - struct ieee80211_supported_band *sband;
> - struct ieee80211_channel *ch;
> - unsigned int i;
> -
> - for (band = 0; band < NUM_NL80211_BANDS; band++) {
> - if (!wiphy->bands[band])
> - continue;
> - sband = wiphy->bands[band];
> - for (i = 0; i < sband->n_channels; i++)
> - ch = &sband->channels[i];
> - }
> -}
> -
> Âstatic int _rtl_reg_notifier_apply(struct wiphy *wiphy,
> Â ÂÂÂstruct regulatory_request *request,
> Â ÂÂÂstruct rtl_regulatory *reg)
> @@ -309,8 +293,6 @@ static int _rtl_reg_notifier_apply(struct wiphy *wiphy,
> Â break;
> Â }
> Â
> - _rtl_dump_channel_map(wiphy);
> -
> Â return 0;
> Â}
> Â

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>