Re: x86 - clang / objtool status

From: Sedat Dilek
Date: Thu Jul 25 2019 - 14:03:25 EST


On Mon, Jul 22, 2019 at 5:40 PM Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
>
> On Fri, Jul 19, 2019 at 3:48 PM Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
> >
> > > First of all I find out that it is possible to download and apply the
> > > series (here: v2) from patchwork (see [1]).
> > > I highly appreciate to have this in Josh's Git [2].
> > >
> >
> > There it is.
> >
> > - sed@ -
> >
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/jpoimboe/linux.git/log/?h=objtool-many-fixes-v2
>
> next-20190722 has them.
>
> Parallely, I opened an CBL issue #617
> "drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool:
> .altinstr_replacement+0x86: redundant UACCESS disable"
>
> I hope Josh can look at this.
>
> - Sedat -
>
> [1] https://github.com/ClangBuiltLinux/linux/issues/617

The objtool warning is fixed by [1].

Now, I see only 3 objtool warnings (all "falls through to next function"):

drivers/gpu/drm/radeon/atom.o: warning: objtool: atom_op_move() falls
through to next function atom_op_and()
drivers/gpu/drm/radeon/evergreen_cs.o: warning: objtool:
evergreen_cs_parse() falls through to next function
evergreen_dma_cs_parse()
drivers/infiniband/hw/hfi1/platform.o: warning: objtool: tune_serdes()
falls through to next function apply_tx_lanes()

The other i915 call-trace I have seen was independent of $COMPILER and
the objtool warning (details see [2] and [3]).

I was able to boot into my system.

- Sedat -

[1] https://lore.kernel.org/patchwork/series/403494/mbox/
[2] https://lore.kernel.org/lkml/20190721142930.GA480@xxxxxxxxxxxxxxxxxxx/
[3] https://github.com/ClangBuiltLinux/linux/issues/617#issuecomment-514906560